Feature: Adds option to define host address#2
Open
docnoe wants to merge 2 commits intoCodermar:masterfrom
Open
Feature: Adds option to define host address#2docnoe wants to merge 2 commits intoCodermar:masterfrom
docnoe wants to merge 2 commits intoCodermar:masterfrom
Conversation
Makes it possible to specify a host address to access the editor if from outside localhost.
Codermar
requested changes
Mar 28, 2020
Owner
Codermar
left a comment
Codermar
left a comment
There was a problem hiding this comment.
Hi, you only need the change in src/index.ts probably or if needed in any of the ts files. The build would override files in the build directory anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to specify a host address e.g. to make it possible to access the editor from outside localhost.